Skip to content

Conversation

tomekkolo
Copy link

jumpstart examples

@tomekkolo tomekkolo requested review from byo and jeroiraz May 13, 2022 10:17
Copy link

@byo byo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments added.

Also github actions are outdated and will not actually run the code samples (they're expecting go files in the go folder)

true,
)
if err != nil {
fmt.Printf("To tu ?")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some debug code?

// This is also how you perform inserts:
_, err = client.SQLExec(context.TODO(),
"UPSERT INTO people(id, name, salary) VALUES (@id, @name, @salary);",
map[string]interface{}{"id": 1, "name": "Joe", "salary": 1000},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're missing some example with positional (unnamed) parameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants