Skip to content

refactor: change images README from enterprise- to example- (pt 2) #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Jul 4, 2025

After #302 is merged, we should rebase this and merge it

@matifali
Copy link
Member

matifali commented Jul 6, 2025

I suggest we keep the enterprise images as they are, deprecate the current enterprise image tags, and move the new example image to ghcr.io instead. See #291

@bpmct bpmct marked this pull request as ready for review July 22, 2025 14:38
@blink-so blink-so bot force-pushed the example-images branch from c481c46 to ada2ad8 Compare July 22, 2025 15:36
@hugodutka
Copy link
Contributor

hugodutka commented Jul 23, 2025

@bpmct what led you back to the approach without the inner loop from #302? Did something go wrong while rebasing? I'm having a bit of trouble following the intent of this PR.

@matifali
Copy link
Member

I suggest we keep the enterprise images as they are, deprecate the current enterprise image tags, and move the new example image to ghcr.io instead. See #291

Discussed with @bpmct on DMs, it's ok to move forward for now. Long term, we do want to move to ghcr.io

@bpmct
Copy link
Member Author

bpmct commented Jul 23, 2025

I think blink just messed up my shit

@bpmct bpmct closed this Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants