🤖 fix: repair terminal-bench agent path and source execution #701
+75
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar-agent
force-pushed
the
debug-terminal-bench-trials
branch
2 times, most recently
from
1a0544e to
4882a8b
Compare
ammario
pushed a commit
that referenced
this pull request
Nov 24, 2025
Generated with `mux` Fixes flaky integration tests observed in PR #701. Changes: - **Runtime Bash Test**: Decoupled tool execution time verification from total test duration. Now measures strict execution time (<10s) using event timestamps, while allowing a generous overall timeout (30s) to accommodate CI network/AI latency. - **Web Search Test**: Lowered `thinkingLevel` to 'low' to improve speed and reliability, and increased timeout to 180s. Verification: - `tests/ipcMain/runtimeExecuteBash.test.ts` passes locally. - `tests/ipcMain/openai-web-search.test.ts` passes locally.
ammar-agent
force-pushed
the
debug-terminal-bench-trials
branch
from
4882a8b to
ddd8cc6
Compare
Updates mux-run.sh to point to correct src/cli/debug/agentSessionCli.ts path. Updates workerPool.ts to support running tokenizer worker from source (Bun) when dist is missing. Updates benchmarking docs to reflect correct path.
Adds scripts/check-bench-agent.sh to verify that the agent entry point referenced in mux-run.sh exists and loads without import errors. Includes this check in the main 'static-check' make target.
ammar-agent
force-pushed
the
debug-terminal-bench-trials
branch
from
ddd8cc6 to
1a518e0
Compare
The previous fix used extname(__filename) === '.ts' to detect source execution, but ts-jest also sets __filename to .ts while running under Node. Node cannot load .ts workers directly (only Bun can), so we now check process.isBun to distinguish between: - Bun running .ts source -> use tokenizer.worker.ts - Node/ts-jest running .ts source -> use tokenizer.worker.js from dist/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects the file path for the terminal-bench agent CLI entry point and fixes worker resolution when running from source.
Changes
src/debug/agentSessionCli.tstosrc/cli/debug/agentSessionCli.ts.tokenizer.worker.tswhen running directly from source (Bun), fixing crash whendist/is missing.Verification
src/cli/debug/agentSessionCli.tsstarts successfully and processes input without worker errors.