Issue 16 create feature box component #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created the component as FeatureBox with two props: width and height, so you can dynamically change its size
Contributor
|
would you please be able to include a screenshot of the component in the PR description? thanks! |
Collaborator
Author
|
Done, tell me if you need any changes |
SafetyInObscurity
requested changes
Nov 29, 2025
Collaborator
SafetyInObscurity
left a comment
SafetyInObscurity
left a comment
There was a problem hiding this comment.
A good start! Some minor details to iron out before the pull
Added a custom dark purple colour to the config and globals files, seen in the desired component in the issue brief, as well as moving Also revised the feature box's props to title and text, instead of height and width (which now change from rem), which are strings that will be placed in the respective parts of the feature box.
SafetyInObscurity
requested changes
Dec 3, 2025
Collaborator
SafetyInObscurity
left a comment
SafetyInObscurity
left a comment
There was a problem hiding this comment.
Looking good! A few steps left for mobile compatibility and simplicity.
| <div | ||
| style={{ | ||
| width: "50rem", | ||
| height: "13rem", |
Collaborator
There was a problem hiding this comment.
I think the issue with the mobile version is this use of a fixed width. Ideally we want the element to fill the space it's given, rather than a fixed value. This also allows it to be used when it's not expected to fill the full viewport width.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Created a component named FeatureBox that fulfills the description of this issue. Along with the special shape, it's title and text contents can be modified per component via props of the same respective names.
Change Form
Other Information
Related issue