[CWA-744] feat: Update promotions for Elementor One & add promotions to additional plugins#329
Open
rami-elementor wants to merge 13 commits intocore-betafrom
Open
[CWA-744] feat: Update promotions for Elementor One & add promotions to additional plugins#329rami-elementor wants to merge 13 commits intocore-betafrom
rami-elementor wants to merge 13 commits intocore-betafrom
Conversation
Collaborator
|
Amazing work @rami-elementor ! |
imantsk
changed the title
sheabunge
requested changes
Jan 20, 2026
src/php/promotions/elementor.php
Outdated
| <div class="notice notice-info is-dismissible code-snippets-promotion"> | ||
| <div class="code-snippets-promotion-icon"> | ||
| <img | ||
| src="<?php echo esc_url( plugins_url( 'assets/icon.svg', CODE_SNIPPETS_FILE ) ); ?>" |
Contributor
Author
There was a problem hiding this comment.
Changing to PLUGIN_FILE causes a critical error:
There has been a critical error on this website. Please check your site admin email inbox for instructions. If you continue to have problems, please try the [support forums](https://wordpress.org/support/forums/).
Contributor
Author
|
Additional plugins: 
|
rami-elementor
changed the title
imantsk
changed the title
imantsk
requested changes
Jan 29, 2026
Member
imantsk
left a comment
imantsk
left a comment
There was a problem hiding this comment.
Overall very nice and scalable structure 👍
spotted a few improvement opportunities.
also if you have a chance please run phpcbf over the the files in this PR to consolidate all indentation and formatting
Comment on lines
40
to
54
| public function get_promotion_buttons(): array { | ||
| return [ | ||
| [ | ||
| 'url' => code_snippets()->get_menu_url(), | ||
| 'text' => esc_html__( 'Manage your snippets', 'code-snippets' ), | ||
| 'class' => 'button button-primary', | ||
| ], | ||
| [ | ||
| 'url' => 'https://codesnippets.pro/pricing/?utm_source=' . $this->get_plugin_slug() . '&utm_medium=promotion&utm_campaign=custom-code', | ||
| 'text' => esc_html__( 'Learn More', 'code-snippets' ), | ||
| 'class' => 'button button-secondary', | ||
| 'target' => '_blank', | ||
| ], | ||
| ]; | ||
| } |
Member
There was a problem hiding this comment.
i see this button building repeats on each promotion class.
this makes me think that it could be standardised and go directly in the base class
| ); | ||
| } | ||
|
|
||
| public function get_promotion_buttons(): array { |
Member
There was a problem hiding this comment.
|
|
||
| wp_send_json_success(); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
we could add this here:
protected function build_default_buttons( bool $show_migrate = false ): array {
$primary = [
'url' => code_snippets()->get_menu_url(),
'text' => esc_html__( 'Manage your snippets', 'code-snippets' ),
'class' => 'button button-primary',
];
if ( $show_migrate ) {
$primary['url'] = add_query_arg( 'tab', 'plugins', code_snippets()->get_menu_url( 'import' ) );
$primary['text'] = esc_html__( 'Migrate to Code Snippets', 'code-snippets' );
}
return [
$primary,
[
'url' => 'https://codesnippets.pro/pricing/?utm_source=' . $this->get_plugin_slug() . '&utm_medium=promotion&utm_campaign=custom-code',
'text' => esc_html__( 'Learn More', 'code-snippets' ),
'class' => 'button button-secondary',
'target' => '_blank',
'rel' => 'noopener noreferrer',
],
];
}
Comment on lines
34
to
46
| return [ | ||
| [ | ||
| 'url' => code_snippets()->get_menu_url(), | ||
| 'text' => esc_html__( 'Manage your snippets', 'code-snippets' ), | ||
| 'class' => 'button button-primary', | ||
| ], | ||
| [ | ||
| 'url' => 'https://codesnippets.pro/pricing/?utm_source=' . $this->get_plugin_slug() . '&utm_medium=promotion&utm_campaign=custom-code', | ||
| 'text' => esc_html__( 'Learn More', 'code-snippets' ), | ||
| 'class' => 'button button-secondary', | ||
| 'target' => '_blank', | ||
| ], | ||
| ]; |
Member
There was a problem hiding this comment.
this can easily become:
return $this->build_default_buttons();ref: https://github.com/codesnippetspro/code-snippets/pull/329/changes#r2743330836
Comment on lines
+39
to
+53
| public function get_promotion_buttons(): array { | ||
| return [ | ||
| [ | ||
| 'url' => code_snippets()->get_menu_url(), | ||
| 'text' => esc_html__( 'Manage your snippets', 'code-snippets' ), | ||
| 'class' => 'button button-primary', | ||
| ], | ||
| [ | ||
| 'url' => 'https://codesnippets.pro/pricing/?utm_source=' . $this->get_plugin_slug() . '&utm_medium=promotion&utm_campaign=custom-code', | ||
| 'text' => esc_html__( 'Learn More', 'code-snippets' ), | ||
| 'class' => 'button button-secondary', | ||
| 'target' => '_blank', | ||
| ], | ||
| ]; | ||
| } |
Member
There was a problem hiding this comment.
Comment on lines
38
to
61
| $buttons = []; | ||
|
|
||
| if ( $this->has_snippets() ) { | ||
| $buttons[] = [ | ||
| 'url' => add_query_arg( 'tab', 'plugins', code_snippets()->get_menu_url( 'import' ) ), | ||
| 'text' => esc_html__( 'Migrate to Code Snippets', 'code-snippets' ), | ||
| 'class' => 'button button-primary', | ||
| ]; | ||
| } else { | ||
| $buttons[] = [ | ||
| 'url' => code_snippets()->get_menu_url(), | ||
| 'text' => esc_html__( 'Manage your snippets', 'code-snippets' ), | ||
| 'class' => 'button button-primary', | ||
| ]; | ||
| } | ||
|
|
||
| $buttons[] = [ | ||
| 'url' => 'https://codesnippets.pro/pricing/?utm_source=' . $this->get_plugin_slug() . '&utm_medium=promotion&utm_campaign=custom-code', | ||
| 'text' => esc_html__( 'Learn More', 'code-snippets' ), | ||
| 'class' => 'button button-secondary', | ||
| 'target' => '_blank', | ||
| ]; | ||
|
|
||
| return $buttons; |
Member
There was a problem hiding this comment.
this can become:
return $this->build_default_buttons( $this->has_snippets() );ref: https://github.com/codesnippetspro/code-snippets/pull/329/changes#r2743330836
Comment on lines
37
to
49
| return [ | ||
| [ | ||
| 'url' => code_snippets()->get_menu_url(), | ||
| 'text' => esc_html__( 'Manage your snippets', 'code-snippets' ), | ||
| 'class' => 'button button-primary', | ||
| ], | ||
| [ | ||
| 'url' => 'https://codesnippets.pro/pricing/?utm_source=' . $this->get_plugin_slug() . '&utm_medium=promotion&utm_campaign=custom-code', | ||
| 'text' => esc_html__( 'Learn More', 'code-snippets' ), | ||
| 'class' => 'button button-secondary', | ||
| 'target' => '_blank', | ||
| ], | ||
| ]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elementor released a new design in WordPress admin, with updated slugs. Promotions for CS should be displayed in the new Custom Code screens.
Promotion in empty archive:
Promotion in archive with custom code:
Promotion in new custom code:
