Skip to content

fixed navbar bug on small devices #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

fixed navbar bug on small devices #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9900393
fixed navbar bug on small devices
tushar912 Aug 12, 2020
622e8dd
push nav right
tushar912 Aug 14, 2020
0a986a0
reverted package-lock.json
tushar912 Aug 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/components/NavBar/NavBar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,12 @@ a:hover{

.blue:hover{
color : lightblue;
}
.nav-scroll{
float:right;

}
#navbarSupportedContent{
width: max-content;
margin-left: auto;
}
24 changes: 13 additions & 11 deletions src/components/NavBar/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useRef } from "react";
import React, { useRef,useState } from "react";
import { Image, Navbar, Container, Nav } from "react-bootstrap";
import "./NavBar.css";
import logo from "../../newlogo.png";
Expand All @@ -15,6 +15,7 @@ const NavBar = () => {
behavior: 'smooth'
});
}
const [expanded, setExpanded] = useState(false);

return (
<React.Fragment>
Expand All @@ -30,7 +31,7 @@ const NavBar = () => {
</Navbar.Brand>
</Navbar>

<Navbar variant="light" bg="light" expand="lg" fixed="top" id="myNav" ref={navbarRef}>
<Navbar expanded={expanded} variant="light" bg="light" expand="lg" fixed="top" id="myNav" ref={navbarRef}>
<Container>
<Navbar.Brand>
<Link to="/">
Expand All @@ -42,50 +43,51 @@ const NavBar = () => {
</Link>
</Navbar.Brand>
<Navbar.Toggle
onClick={() => setExpanded(expanded ? false : "expanded")}
lable="Toggle navigation"
aria-controls="navbarSupportedContent">
</Navbar.Toggle>
<Navbar.Collapse id="navbarSupportedContent">
<Nav className="ml-auto">
<Nav className ='nav-scroll'>
<Nav.Item>
<Link scroll={smoothScroll} className="nav-link" to="/#aboutUs">
<Link scroll={smoothScroll} className="nav-link" to="/#aboutUs" onClick={() => setExpanded(expanded ? false : "expanded")}>
About Us<span className="sr-only">(current)</span>
</Link>
</Nav.Item>
<Nav.Item>
<Link scroll={smoothScroll} className="nav-link" to="/#projects">
<Link scroll={smoothScroll} className="nav-link" to="/#projects" onClick={() => setExpanded(expanded ? false : "expanded")}>
Project<span className="sr-only">(current)</span>
</Link>
</Nav.Item>
<Nav.Item>
<Link scroll={smoothScroll} className="nav-link" to="/#programs">
<Link scroll={smoothScroll} className="nav-link" to="/#programs" onClick={() => setExpanded(expanded ? false : "expanded")}>
Programs<span className="sr-only">(current)</span>
</Link>
</Nav.Item>
<Nav.Item>
<Link className="nav-link" to="/team">
<Link className="nav-link" to="/team" onClick={() => setExpanded(expanded ? false : "expanded")}>
Team<span className="sr-only">(current)</span>
</Link>
</Nav.Item>
<Nav.Item>
<a
className="nav-link"
href="https://docs.codeuino.org/documentation/">
href="https://docs.codeuino.org/documentation/" onClick={() => setExpanded(expanded ? false : "expanded")}>
Docs<span className="sr-only">(current)</span>
</a>
</Nav.Item>
<Nav.Item>
<Link scroll={smoothScroll} className="nav-link" to="/#collaborate">
<Link scroll={smoothScroll} className="nav-link" to="/#collaborate" onClick={() => setExpanded(expanded ? false : "expanded")}>
Collaborate<span className="sr-only">(current)</span>
</Link>
</Nav.Item>
<Nav.Item>
<Link className="nav-link" to="/codeofconduct">
<Link className="nav-link" to="/codeofconduct" onClick={() => setExpanded(expanded ? false : "expanded")}>
Code of Conduct<span className="sr-only">(current)</span>
</Link>
</Nav.Item>
<Nav.Item>
<Link className="nav-link" to="/joinus">
<Link className="nav-link" to="/joinus" onClick={() => setExpanded(expanded ? false : "expanded")}>
Join Us<span className="sr-only">(current)</span>
</Link>
</Nav.Item>
Expand Down