Skip to content

fix: Backspaces do not work when the code block contains initial data. #2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: next
Choose a base branch
from
Open

fix: Backspaces do not work when the code block contains initial data. #2836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7a404db
fix: Do not search Leaf when argument input is Native input
yosipy Oct 4, 2024
8cec5c9
refactor: determine whether it is native input in getDeepestNode
yosipy Oct 5, 2024
60692ae
Merge branch 'next' into patch-1
yosipy Oct 9, 2024
2b624d2
Merge branch 'next' into patch-1
yosipy Oct 10, 2024
316514e
Update CHANGELOG.md
yosipy Oct 10, 2024
971be28
Revert "Update CHANGELOG.md"
yosipy Oct 10, 2024
3282b43
Update CHANGELOG.md
yosipy Oct 10, 2024
62d3942
Merge branch 'next' into patch-1
yosipy Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- `Fix` - Fix selection of first block in read-only initialization with "autofocus=true"
- `Fix` - Incorrect caret position after blocks merging in Safari
- `Fix` - Several toolbox items exported by the one tool have the same shortcut displayed in toolbox
- `Fix` - Fixed BackSpace not working on CodeBlock with initial data

### 2.30.6

Expand Down
2 changes: 1 addition & 1 deletion src/components/dom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ export default class Dom {
const child = atLast ? 'lastChild' : 'firstChild',
sibling = atLast ? 'previousSibling' : 'nextSibling';

if (node && node.nodeType === Node.ELEMENT_NODE && node[child]) {
if (node && node.nodeType === Node.ELEMENT_NODE && node[child] && !Dom.isNativeInput(node)) {
let nodeChild = node[child] as Node;

/**
Expand Down