Open
Conversation
When no FEATURE is passed to make test, results of test shouldn't be ignored, so CI can work properly
kawazaki0
approved these changes
Apr 19, 2019
Contributor
|
Here is the source of the problem https://github.com/codilime/acid/pull/54/files#diff-b67911656ef5d18c4ae36cb6741b7965L41 . The changed line |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no FEATURE is passed to make test, results of test shouldn't be ignored. At this moment, any test result is ignored and CI can't catch errors - they are stored in log, but not showed in status.