Adds Redis Sentinel backend #404
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Talking with Frank about this, will circle back soon! |
codingjoe
reviewed
Dec 19, 2025
Owner
codingjoe
left a comment
codingjoe
left a comment
There was a problem hiding this comment.
Hi @richardARPANET 👋,
Thank you for your contribution! I haven't used it myself. Usually, I'd love to have to spin up the environment in CI or locally to do proper e2e tests.
This might be a suitable candidate for a third-party package. However, don't hesitate to add tests and maybe some container orchestration to test against an actual Sentinel cluster.
I will keep this PR open for a few weeks to see if this is still something you are interested in contributing to.
Thanks,
Joe
Comment on lines
+1
to
+4
| import django | ||
|
|
||
| if django.VERSION < (3, 2): | ||
| default_app_config = "health_check.contrib.redis_sentinel.apps.HealthCheckConfig" |
Owner
There was a problem hiding this comment.
That'll be no longer needed. 3.2 is EoL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As above