Enable logging on dms related utility and extension methods#652
Open
ozangoktan wants to merge 1 commit intomasterfrom
Open
Enable logging on dms related utility and extension methods#652ozangoktan wants to merge 1 commit intomasterfrom
ozangoktan wants to merge 1 commit intomasterfrom
Conversation
Contributor
Author
|
/gemini review |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #652 +/- ##
==========================================
+ Coverage 77.71% 77.82% +0.11%
==========================================
Files 136 136
Lines 13226 13228 +2
Branches 1991 1991
==========================================
+ Hits 10278 10295 +17
+ Misses 2112 2095 -17
- Partials 836 838 +2
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request updates the CogniteUtils class to include new logger initializations for DataModelUtils and DataPointExtensionsWithInstanceId, while adjusting namespace imports. Additionally, the project version has been bumped from 1.40.0 to 1.41.0. I have no feedback to provide.
nithinb
approved these changes
Apr 1, 2026
|
🦄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like logger injection methods for these static extension classes were never added to the central method that injects the logger for all the extensions. This PR fixes that.