Skip to content

Fix log message for Loading app config from CDF#518

Open
Yaseen-A-Khan wants to merge 1 commit intomasterfrom
yaseen/update-loading-cdf
Open

Fix log message for Loading app config from CDF#518
Yaseen-A-Khan wants to merge 1 commit intomasterfrom
yaseen/update-loading-cdf

Conversation

@Yaseen-A-Khan
Copy link
Copy Markdown

@Yaseen-A-Khan Yaseen-A-Khan commented Apr 6, 2026

The log showed repeated "Loading application config from CDF" when the config in the integrations UI is invalid.
If same error were to repeat, it wasn't logged.

This PR:

  • logs the invalid error message along with the "Loading application config from CDF" so that the user has more context why there is trouble in loading the config from CDF

@Yaseen-A-Khan Yaseen-A-Khan requested a review from a team as a code owner April 6, 2026 07:20
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the observability of the application configuration loading process. By ensuring that recurring errors are logged, it provides users with necessary context when configuration retrieval from CDF fails, preventing silent failures during retry loops.

Highlights

  • Improved Error Logging: Modified the configuration loading logic to ensure that repeated errors are logged instead of being suppressed, providing better visibility into configuration issues.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the error handling in the _safe_get_application_config method to ensure that repeated errors are logged instead of being suppressed. The reviewer suggested refactoring the code to log the error message unconditionally, which simplifies the logic and removes the current duplication of the logging call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant