🐛 fix(favorites): apply wallpaper to desktop when browsing favorites#2
Merged
🐛 fix(favorites): apply wallpaper to desktop when browsing favorites#2
Conversation
Favorites navigation only loaded a cached preview image but never called setDesktopImageURL, so the desktop wallpaper stayed unchanged. Replace loadFavoritePreview() with applyFavoriteAtIndex() that downloads (if needed) and applies the wallpaper on all screens. Also disambiguate the favorite-toggle button (now star/yellow) from the favorites-browse button (heart/pink) to eliminate UX confusion, remove the redundant desktopcomputer apply button, add tap-to-close on the favorites panel, and add descriptive tooltips to all actions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setDesktopImageURL)Test plan
just test— all 25 existing tests pass