Open
Conversation
Adds new arguments the `pytest.yaml` reusable workflow, to make it easier to specify a strategy. To generate the strategy, a small utility `genstrat.py` has been added. By default, this utility will output a file identical to the old `strategy.json` (which has been deleted). It is still possible to use `matrix-filter`, if a user prefers to use that. Resolves: colcon#37
Author
|
Can someone please look at this PR? |
Author
|
So I know there was a response to #37, but I wonder if you might still consider merging this PR? It doesn't add too much code, it is backwards compatible. This is just my opinion, but I think it's easier to understand than the |
Author
|
Here's my Colcon extension, and the workflow using the updated action: https://github.com/taughz/colcon-package-of/blob/98cc23b70348a2b171cf6f48415dacb934047032/.github/workflows/ci.yaml#L16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new arguments the
pytest.yamlreusable workflow, to make it easier to specify a strategy. To generate the strategy, a small utilitygenstrat.pyhas been added. By default, this utility will output a file identical to the oldstrategy.json(which has been deleted). It is still possible to usematrix-filter, if a user prefers to use that.Resolves: #37