Skip to content

Run RF tests on PhantomJS instead of Firefox#732

Closed
hvelarde wants to merge 2 commits intomasterfrom
hvelarde-phantomjs
Closed

Run RF tests on PhantomJS instead of Firefox#732
hvelarde wants to merge 2 commits intomasterfrom
hvelarde-phantomjs

Conversation

@hvelarde
Copy link
Copy Markdown
Member

No description provided.

@hvelarde hvelarde requested a review from datakurre June 20, 2017 22:37
@hvelarde
Copy link
Copy Markdown
Member Author

@datakurre could you please give some advice here? do you know why tests are failing?

@idgserpro
Copy link
Copy Markdown
Member

Shouldn't we test on both?

@datakurre
Copy link
Copy Markdown
Contributor

I guess this is because Firefox selenium dependencies are currently really hard, because of each new versions requiring too often both the latest selenium and the latest geckodriver.

@hvelarde PhantomJS may run in mobile window size by default. Do you already have Set window size 1200 900 or similar in the tests?

@hvelarde
Copy link
Copy Markdown
Member Author

@datakurre no, I don't; that's the recommended size? I'll test later.

@hvelarde
Copy link
Copy Markdown
Member Author

@datakurre seems it's not working neither; let me know if you have another idea.

@idgserpro
Copy link
Copy Markdown
Member

Why phantomjs instead of chrome? Do you want to get rid of drivers nightmare?

@hvelarde
Copy link
Copy Markdown
Member Author

superseded by #784

@hvelarde hvelarde closed this Jun 26, 2018
@hvelarde hvelarde deleted the hvelarde-phantomjs branch June 26, 2018 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants