Update webpack configuration to respect Plone excludes URL#848
Update webpack configuration to respect Plone excludes URL#848
Conversation
rodfersou
force-pushed
the
update-webpack-configuration
branch
from
c9643c9 to
c0e6679
Compare
| cursor: pointer; | ||
| // FIXME - https://github.com/simplesconsultoria/sc.recipe.staticresources/issues/44 | ||
| background-image: url('./img/pb_close.png'); | ||
| background-image: url('++resource++plone.app.jquerytools.pb_close.png'); |
There was a problem hiding this comment.
hvelarde
left a comment
hvelarde
left a comment
There was a problem hiding this comment.
seems something is still not ready with this pull request; seems you need to run webpack to copy the template to the right place.
do you need something else?
|
@hvelarde this PR depends on merge/fix this first: https://github.com/simplesconsultoria/sc.recipe.staticresources/pull/56/files and update references in package.json file |
| height: 30px; | ||
| cursor: pointer; | ||
| // FIXME - https://github.com/simplesconsultoria/sc.recipe.staticresources/issues/44 | ||
| background-image: url('./img/pb_close.png'); |
There was a problem hiding this comment.
You must exclude the image itself.
Did you have to copy another resource or was it just this one?
| "license": "GPL-2.0", | ||
| "dependencies": { | ||
| "sc-recipe-staticresources": "simplesconsultoria/sc.recipe.staticresources#1.1b5" | ||
| "sc-recipe-staticresources": "simplesconsultoria/sc.recipe.staticresources#1.2b0" |
There was a problem hiding this comment.
Fix package namespace and version.
|
@rodfersou now that you've finished collective/sc.recipe.staticresources#56, do you intend to finish this one? In any IDG package did you need to copy resources from other packages? |
|
@idgserpro unfortunately I don't have spare time next month to work on it.. but basically need to update staticresources version and maybe reference some images outside this package instead of make a copy. If you want to give it a try, I can review the changes. |
3 participants
Depends on https://github.com/simplesconsultoria/sc.recipe.staticresources/pull/56/files
And a new release of
sc.recipe.staticresources