Conversation
ale-rt
requested changes
Feb 20, 2023
Member
ale-rt
left a comment
ale-rt
left a comment
There was a problem hiding this comment.
That's really desirable, thanks!
I would update the classifiers in setup.py.
This PR breaks Python2.7 compatibility.
I would use six to make at least one release compatible with Plone5.2/Python2.7 so that we can have a proper migration path.
I have added a comment about a comment that it looks to me like a typo :)
refactoring Controlpanel with p.a.registry RegistryEditForm wrapper (z3c.form)
Author
|
I've ported code so that it could work with py2 and py3. Ported the ControlPanel to newer implementation. |
Member
|
Your changes look good to me but I think it would a nice thing to also have the button rendered |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@alecpm