Add dependency on plone.formwidget.namedfile 1.0.15+#173
Open
tobiasherp wants to merge 2 commits intocollective:masterfrom
Open
Add dependency on plone.formwidget.namedfile 1.0.15+#173tobiasherp wants to merge 2 commits intocollective:masterfrom
tobiasherp wants to merge 2 commits intocollective:masterfrom
Conversation
(... which have been created by virtualenv .)
plone.formwidget.namedfile 1.0.9 (KGS of Plone 4.3.3) lacks the b64decode_file function; v1.0.15 (KGS 4.3.9 to 4.3.18) has it. Looking at the history, it seems it has been added in version 1.0.12, but buildout couldn't find a distribution for this.
Member
|
@hvelarde we really need this. See: |
idgserpro
approved these changes
Jul 30, 2019
|
I think adding the dependency just because of this function is not optimal. The function is pretty simple, and depends only on the base64 module from the stdlib: I'd rather duplicate the function. Just my 2 cents. |
Member
|
@rafaelbco it's not just because of the function. The widget is also used: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... because of the
b64decode_filefunction.