Conversation
So that users can decide whether to use json_spec with RSpec or MiniTest.
|
Awesome, thank you! 👏 I don't personally use MiniTest but I'm going to try to pull somebody in who does to review this before I pull. |
|
@blowmage this is a very nice addition, thank you! 👍 from me. |
|
@laserlemon: @jasonroelofs keeps talking about how we should use MiniTest more, he might be a good candidate |
|
By all means @jasonroelofs, please chime in! |
|
Well you guys know me, I love MiniTest and anything that helps people use MiniTest more is 👍 from me! |
|
@jasonroelofs If you get a second, could you take a look at the commits/changes and let us know how it looks from another MiniTest user's perspective? |
|
@blowmage I swear I don't distrust you as much as it sounds in this thread! |
|
@laserlemon lulz! |
|
Nothing jumps out at me with this commit. As it is trying to keep the syntax of json_spec the same while allowing the use of MiniTest or Rspec under the hood I'd say it's done a good job of that. |
|
+1 |
|
Hi is this pulled? We'd like to make use of your gem in our minitest specs. Thx!! |
There was a problem hiding this comment.
If we are expanding these matchers to work elsewhere I'd rather have all configuration taken care either in its own file or required by the user in the test helper.
For rspec we could require the user to simply add this configuration to their spec_helper.
For minitest is there any better way to handle registering methods, so we could take them out of this file?
Are the classic assertions still highly used of could we get by without supporting them?
|
+1 |
9 participants
Allow json_spec to be used from minitest tests.