Skip to content

feat: consistent input validation with tool execution errors#56

Merged
bobby-smedley merged 1 commit intomainfrom
feat/validate-tool-inputs
Apr 22, 2026
Merged

feat: consistent input validation with tool execution errors#56
bobby-smedley merged 1 commit intomainfrom
feat/validate-tool-inputs

Conversation

@bobby-smedley
Copy link
Copy Markdown
Contributor

🎯 What does this PR do?

Core change - SDK upgrade (enables schema-level validation → isError:true):

  • go.mod/go.sum: SDK v1.1.0 → v1.5.0
  • pkg/chip/server_test.go: two tests proving missing-required / wrong-type return isError: true

New validation helpers:

  • pkg/tools/validation/uuid.go: UUID, UUIDOptional, UUIDs + tests

UUID validation added to 10 tool handlers:

  • add_business_term, add_data_classification_match, create_asset, get_asset_details, get_business_term_data, get_column_semantics, get_measure_data, get_table_semantics, pull_data_contract_manifest, remove_data_classification_match,
    search_asset_keyword, search_lineage_entities

All bad-UUID paths now return Go error → SDK wraps as isError: true.

Tests updated to use valid UUID-format placeholders and the new error contract.

✅ Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (if needed).
  • My commit messages follow the Conventional Commits standard.

@bobby-smedley bobby-smedley requested a review from a team as a code owner April 20, 2026 16:31
@bobby-smedley bobby-smedley merged commit 7348a7c into main Apr 22, 2026
1 check passed
@bobby-smedley bobby-smedley deleted the feat/validate-tool-inputs branch April 22, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants