Skip to content

Chore/fix linting #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codatoz merged 2 commits into from
Aug 28, 2025
Merged

Chore/fix linting #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0135dbd
Fix linting
codatoz Aug 27, 2025
b7a417f
Disable sonarqube
codatoz Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,30 +26,30 @@ jobs:
- name: Lint
uses: golangci/golangci-lint-action@v8
with:
version: v2.1.6
version: v2.4.0

- name: Build
run: go build ./...

- name: Test
run: make test

- name: SonarQube Scan
uses: sonarsource/sonarqube-scan-action@v4
env:
SONAR_TOKEN: ${{ secrets.SONARQUBE_TOKEN }}
SONAR_HOST_URL: https://sonarqube.collibra.dev
with:
args: >
-Dsonar.pullrequest.github.repository=collibra/go-set

- name: SonarQube Quality Gate
uses: sonarsource/sonarqube-quality-gate-action@v1.1.0
timeout-minutes: 10
continue-on-error: true
env:
SONAR_TOKEN: ${{ secrets.SONARQUBE_TOKEN }}
SONAR_HOST_URL: https://sonarqube.collibra.dev
# - name: SonarQube Scan
# uses: sonarsource/sonarqube-scan-action@v4
# env:
# SONAR_TOKEN: ${{ secrets.SONARQUBE_TOKEN }}
# SONAR_HOST_URL: https://sonarqube.collibra.dev
# with:
# args: >
# -Dsonar.pullrequest.github.repository=collibra/go-set
#
# - name: SonarQube Quality Gate
# uses: sonarsource/sonarqube-quality-gate-action@v1.1.0
# timeout-minutes: 10
# continue-on-error: true
# env:
# SONAR_TOKEN: ${{ secrets.SONARQUBE_TOKEN }}
# SONAR_HOST_URL: https://sonarqube.collibra.dev

- name: FOSSA Scan
uses: fossas/fossa-action@v1
Expand Down
12 changes: 8 additions & 4 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ linters:
- unparam
- unused
- whitespace
- wsl
- wsl_v5
settings:
cyclop:
max-complexity: 20
Expand Down Expand Up @@ -102,9 +102,13 @@ linters:
- .WithMessagef(
- .WithStack(
- go-multierror.Append(
wsl:
allow-assign-and-anything: true
allow-cuddle-declarations: true
wsl_v5:
allow-first-in-block: true
allow-whole-block: false
branch-max-lines: 2
disable:
- assign
- decl
exclusions:
generated: lax
presets:
Expand Down