Skip to content

Grading PR - Feedback and Comments#46

Open
martypdx wants to merge 2 commits intocolordiary:masterfrom
martypdx:master
Open

Grading PR - Feedback and Comments#46
martypdx wants to merge 2 commits intocolordiary:masterfrom
martypdx:master

Conversation

@martypdx
Copy link
Copy Markdown

@martypdx martypdx commented Apr 7, 2017

  • Failed the npm i && npm test test (couple of failing tests)
  • tests need to have assertions :(
  • test files don't seem to have been linted :(
    • and have a lot of unused imports
  • seed data should not be in lib folder (should be a sibling to lib). It's not part of the "library" code
  • Queries against a route should not be separate routes, by same route with different query.
  • Some of the more complex query logic could move into the model as well
  • Nice work on the models, I think the data model contributed to snappy app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant