-
Notifications
You must be signed in to change notification settings - Fork 0
Specification v0.1 Release #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Zhav Loizeau Initial CommentsI think there is an implicit choice about the word “observation” that is used to name what is called “measured values” in the GUM. Might be worth making explicit? Goal
Maybe giving examples of how this complexity is characterised could be interesting (multi-modal, increasing number of “dimensions”, …) Variables
Maybe one needs to distinguish “size in memory” and “conceptual size”. If an error covariance matrix is specified to be of “scalar” type, that is, each measured values are associated with an uncertainty with the same value Image, and the errors are independent, one only needs to store Image in memory. However, knowing that the measured value vector has size Image, and that the error covariance Image matrix has such a structure, they can still perform the required operations. For instance Image will return Image and Image will return Image for Image and Image. I hope that addresses the question? Dimensions
Maybe “Strictly positive integer size”? Data types
In interferometric SAR, I think the data should be stored as complex numbers, no? Possibly relevant Attributes
Should there be a constraint that each uncertainty variable should be linked to a single observation variable? Also, should there be a “how” uncertainty variable is linked to observation variable? I know we mostly deal with additive errors but should there be some way to say if some error is multiplicative for example? Units
I am a bit unsure about this choice. In an error-covariance matrix, the values in the matrix are covariances and variances which have the unit of the measurand squared, while in an error-correlation matrix, the entries are unitless. Uncertainty PDF shapeWhy name the uniform distribution rectangular and not uniform?
Wikipedia has a helpful selection (as always). I would say some “most have” are:
I understand that you assume mean 0 and, in the uniform and gaussian case, all you need is the variance parameter stored in the uncertainty variable to completely characterise the distribution. What happens for families of distributions with more parameters? Parameterisating Error-Correlation MatricesI noticed a likely typo in the title (parameterisating instead of parameterising?) Maybe a short paragraph describing how one obtains the error-covariance matrix from the error-correlation matrix and the uncertainty vector would be good. Actually having such a note early on to dis-ambiguate, and be clear about what should be stored in memory? I cannot not comment on “random” form because I reaaaaally wish it were either “un-correlated”, “independent” (this is not quite true as one can define un-correlated random variables that are dependent e.g., Image), or “diagonal” (to describe the shape of the matrix). Parameterisation based on Matrix structure
Still no standard in sight. As mentioned before, there is a Wikipedia page (why not). |
|
I've combined comments from me and comments from Peter Harris in this single document - he's the yellow "pmh" and I'm the pink "erh" - you'll see I tried to write Emma early on, but it didn't default to that and I couldn't be bothered to change them all (erh is my user name as when I joined NPL I was Emma Hobbs). You've done a great job to start this process - and it's something we need for ARIA. You've thought through a lot and there are no enormous concerns. There are also things I realise I don't understand, so if some of my comments are unconstructive, treat them as my confusion and perhaps provide a bit more background in. |
Description
Review for initial release of UNC Specification website. Find on the site:
Review
Based on comments in this PR, we are adding to an Issue Milestone - to be completed before we merge to main. Specific topics can be discussed in those issues.
Completion of the issues in this milestone is being managed in a corresponding Project.