Conversation
- Fix dyld "Library not loaded: libpython3.12.dylib" error on macOS by using UVCommand (bundled uv) for venv creation with symlinks, falling back to venv.create(..., symlinks=True) if unavailable - Fix incorrect --cpu flag on macOS by detecting platform - PyTorch MPS builds don't have a version suffix like CUDA (+cu128), so on Darwin treat no suffix as MPS rather than CPU-only - Make comfygit-dev script portable across macOS/Linux/WSL by auto- detecting CORE_PATH relative to manager path instead of hardcoded path - Update tests to verify uv-first strategy and stdlib fallback behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dyld: Library not loaded: libpython3.12.dylib--cpuflag being added on macOS (should use MPS)comfygit-devscript portable across macOS/Linux/WSLChanges
Orchestrator Venv Fix (
server/orchestrator.py)The orchestrator venv was failing on macOS because
venv.create()copied Python binaries with hardcoded@executable_path/../lib/libpython3.12.dylibpaths, but didn't copy the actual dylib.Solution: Use
UVCommandfromcomfygit_core(bundled uv binary) which creates symlinks by default, falling back tovenv.create(..., symlinks=True)if unavailable.MPS Detection Fix (
server/orchestrator.py)PyTorch MPS builds on macOS don't have a version suffix (like
+cu128for CUDA). The code was incorrectly treating no-suffix as CPU-only and adding--cpuflag.Solution: Check platform - on Darwin, no suffix means MPS build, not CPU-only.
Portable Dev Script (
scripts/comfygit-dev)CORE_PATHas sibling repo instead of hardcoded Linux pathCOMFYUIpath to$HOME/ComfyUITest plan
uv run pytest testing/unit/test_orchestrator_venv.py)