Conversation
ComfyUI frontend v1.33.9 removed the import map plugin (PR #6899) that previously exposed Vue and related dependencies to extensions. Extensions using `rollupOptions.external: ['vue', ...]` now fail with: "Failed to resolve module specifier 'vue'" Per official guidance (Issue #7267), extensions must now bundle Vue directly. This removes Vue, vue-i18n, pinia, and primevue from the external list so they get bundled into comfygit-panel.js. Also: - Define process.env.NODE_ENV='production' to fix browser runtime error - Fix version check script to avoid matching Vue's version number Bundle size increases from ~100KB to ~176KB (gzipped) but now works on both old (v1.32.x) and new (v1.33.9+) ComfyUI versions. Context: ctx://46f65107e266912e/c582c011-b93d-451a-94b2-8bb32f70fc1b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ComfyUI frontend v1.33.9 removed the import map plugin (PR #6899) that previously exposed Vue and related dependencies to extensions. This broke our Vue-based panel with the error:
Per official guidance, extensions must now bundle Vue directly.
Changes
Impact
Test Plan