refactor: Creates a shared Banner styles file#849
Merged
curlyfriesplease merged 3 commits intomasterfrom Mar 5, 2026
Merged
Conversation
… so much duplicated style code
curlyfriesplease
changed the title
curlyfriesplease
commented
Mar 5, 2026
| return ( | ||
| <FormWrapper | ||
| donateOrientation={donateOrientation} | ||
| shouldShowTitleSection={shouldShowTitleSection} |
Contributor
Author
There was a problem hiding this comment.
Realised I didn't need this line, styles don't use it
AndyEPhipps
reviewed
Mar 5, 2026
| <div | ||
| aria-live="polite" | ||
| className="c2" | ||
| orientation="right" |
Contributor
There was a problem hiding this comment.
Whoops, these need to be $transientProps; I always forget about em too
I guess the previous camelCasing of the longer name marks them as transient automatically, hence this only showing up now?
Contributor
Author
There was a problem hiding this comment.
That is a good shout. And a good theory about why.
Pushing a fix momentarily
…ing drilled where unnecessary
AndyEPhipps
approved these changes
Mar 5, 2026
|
🎉 This PR is included in version 8.62.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
What is it doing?
Tidyup of my Email & Donate banner work: They have a huge amount of duplicated styling code between them.
It's important to have them reference shared styles or inevitably they'll stop mirroring each other as things change.
HeroBanner's styles has some similarities in places, but no overlaps enough to pull out of that too.
Why is this required?
Refactor, code tidyup
link to Jira ticket:
ENG-4433
Quick Checklist:
My PR title follows the Conventional Commit spec.
I have filled out the PR description as per the template above.
I have added tests to cover new or changed behaviour.
I have updated any relevant documentation.
Important! - lastly, make sure to squash merge...