Open
Conversation
4ecc1de to
bebe7e7
Compare
The `swap/second` returns a SCEAddress with null `tx_backup_addr` and `transfer_sender` function uses this to replace the previous owner. If the `tx_backup_addr` is null, the previous owner persists and then the error `Backup Tx Receiving Address not found in this wallet` occurs in the swap process. Using `proof_key` to set the new owner in the backup transaction fix this.
2ff6b24 to
5c5d197
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the blind signature feature, both on the server (
server_lib::protocol::ecdsa::StateChainEntity fn sign_second_blinded) and on the client (client_lib::ecdsa::sign pub fn blinded_sign).The client generates a blinding factor and blinds the partial signature via homomorphic scalar multiplication and then sends it to the server (SE).
The server signs without knowing the content of the transaction and the
rpart of the signature is also not sent to the server.The client then unblinds the signature returned by server to get the final signature.
It also verifies the signature (
r,s) against the message (transaction) and the shared public key.This is a work in progress so there will be changes, but the code is ready for review.