Skip to content

Better login errors #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ollietheotter983 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Better login errors #677

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9d7d0ff
Alternative solution for better login errors
ollietheotter983 Feb 16, 2026
490ec21
Updating variables
ollietheotter983 Feb 17, 2026
de64d00
use showAdaptiveDialog
ollietheotter983 Feb 17, 2026
6faf636
Realiing the error of my ways
ollietheotter983 Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions commet/lib/ui/pages/login/login_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import 'package:commet/utils/debounce.dart';
import 'package:commet/utils/rng.dart';
import 'package:flutter/material.dart';
import 'package:intl/intl.dart';
import 'package:commet/ui/navigation/adaptive_dialog.dart';

class LoginPage extends StatefulWidget {
const LoginPage({super.key, this.onSuccess, this.canNavigateBack = false});
Expand All @@ -19,15 +20,16 @@ class LoginPage extends StatefulWidget {
State<LoginPage> createState() => LoginPageState();
}


class LoginPageState extends State<LoginPage> {
String get messageLoginFailed => Intl.message("Login Failed...",
name: "messageLoginFailed",
desc: "Generic text to show that an attempted login has failed");

String get messageLoginError => Intl.message("An error occured",
name: "messageLoginError",
String get messageLoginIncorrect => Intl.message("Incorrect username or password.",
name: "messageLoginIncorrect",
desc:
"A generic error message to convey that an error occured when attempting to login");
"A generic error message to convey that an error occured when attempting to login, usually an invalid username or password.");

String get messageAlreadyLoggedIn => Intl.message(
"You have already logged in to this account",
Expand Down Expand Up @@ -109,20 +111,21 @@ class LoginPageState extends State<LoginPage> {
String? message = switch (result) {
LoginResult.success => null,
LoginResult.failed => messageLoginFailed,
LoginResult.error => messageLoginError,
LoginResult.error => messageLoginIncorrect,
LoginResult.alreadyLoggedIn => messageAlreadyLoggedIn,
LoginResult.cancelled => "Login cancelled"
};

if (message != null) {
if (mounted) {
ScaffoldMessenger.of(context).showSnackBar(
SnackBar(
content: Text(message),
),
);
AdaptiveDialog.show(
context,
title: "Login failed",
builder: (_) => Text("Incorrect login. Ensure that you have entered your username and password correctly, and that you have entered the homeserver address correctly.")
);
};
}
}


if (result == LoginResult.success) {
clientManager?.addClient(loginClient!);
Expand Down
Loading