Skip to content

Remove misleading space push settings #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ollietheotter983 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove misleading space push settings #679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions commet/lib/ui/pages/settings/categories/space/space_general_settings_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,22 +15,11 @@ class SpaceGeneralSettingsPage extends StatefulWidget {
}

class _SpaceGeneralSettingsPageState extends State<SpaceGeneralSettingsPage> {
late PushRule pushRule;

@override
void initState() {
pushRule = widget.space.pushRule;
super.initState();
}

@override
Widget build(BuildContext context) {
return Column(
children: [
RoomGeneralSettingsView(
pushRule: pushRule,
onPushRuleChanged: setPushRule,
),
const SizedBox(
height: 10,
),
Expand All @@ -39,14 +28,4 @@ class _SpaceGeneralSettingsPageState extends State<SpaceGeneralSettingsPage> {
],
);
}

void setPushRule(PushRule? rule) {
if (rule == null) return;

setState(() {
pushRule = rule;
});

widget.space.setPushRule(rule);
}
}
Loading