Skip to content

fix(dependencies): update tomlkit version to >=0.8.0,<1.0.0 #1578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Narwhal-fish
Copy link

Description

Update the tomlkit dependency in pyproject.toml to >=0.8.0,<1.0.0 to support parsing TOML files with empty keys (e.g., { "" = "src" }).

This PR addresses #1573, which requests an upgrade of tomlkit.
Although the issue was discussed in tomlkit#17, the actual fix was implemented in python-poetry/tomlkit#143 and released in tomlkit v0.8.0.

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run poetry doc locally to ensure the documentation pages renders correctly
  • Check and fix any broken links (internal or external) in the documentation

Expected Behavior

Steps to Test This Pull Request

Additional Context

@Narwhal-fish Narwhal-fish changed the title fix(dependencies): update tomlkit version to >=0.8.0,<1.0.0 [WIP] fix(dependencies): update tomlkit version to >=0.8.0,<1.0.0 Aug 19, 2025
@Lee-W Lee-W changed the base branch from master to v4-9-0-test August 20, 2025 01:02
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v4-9-0-test@3b00235). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             v4-9-0-test    #1578   +/-   ##
==============================================
  Coverage               ?   98.35%           
==============================================
  Files                  ?       58           
  Lines                  ?     2671           
  Branches               ?        0           
==============================================
  Hits                   ?     2627           
  Misses                 ?       44           
  Partials               ?        0           
Flag Coverage Δ
unittests 98.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Narwhal-fish Narwhal-fish force-pushed the fix/update-tomlkit-to-allow-empty-keys-in-pyproject-toml branch from 91ee11f to 976f641 Compare August 21, 2025 18:14
@Lee-W Lee-W force-pushed the fix/update-tomlkit-to-allow-empty-keys-in-pyproject-toml branch from 976f641 to 5c01885 Compare August 24, 2025 11:11
@Lee-W
Copy link
Member

Lee-W commented Aug 24, 2025

It includes one unintentional commit. I'll go ahead and reorganize the commits a bit and then merge it

@Lee-W Lee-W changed the title [WIP] fix(dependencies): update tomlkit version to >=0.8.0,<1.0.0 fix(dependencies): update tomlkit version to >=0.8.0,<1.0.0 Aug 24, 2025
@Lee-W Lee-W force-pushed the fix/update-tomlkit-to-allow-empty-keys-in-pyproject-toml branch from 5c01885 to 6ee35d1 Compare August 24, 2025 11:16
@Lee-W Lee-W added pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check and removed pr-status: wait-for-review labels Aug 24, 2025
@Lee-W Lee-W added this to the 4.9.0 milestone Aug 24, 2025
@Lee-W Lee-W merged commit 69db5b4 into commitizen-tools:v4-9-0-test Aug 24, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants