Skip to content

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Sep 2, 2022

Only 7 test failures!

  • all CWL documents are first upgraded to CWL v1.2 (or whatever cwl-upgrader thinks is "latest"); this is a big change in behavior
    • reasoning: to hand mixed versions cleanly...

Aim to address #1728

@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.70%. Comparing base (2a2216b) to head (cbc0a69).
⚠️ Report is 388 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (2a2216b) and HEAD (cbc0a69). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (2a2216b) HEAD (cbc0a69)
14 8
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1730       +/-   ##
===========================================
- Coverage   66.60%   55.70%   -10.91%     
===========================================
  Files          89       44       -45     
  Lines       15854     7750     -8104     
  Branches     4190     1990     -2200     
===========================================
- Hits        10560     4317     -6243     
+ Misses       4206     2909     -1297     
+ Partials     1088      524      -564     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mr-c
Copy link
Member Author

mr-c commented Sep 2, 2022

Some of the test failures are due to slightly different behavior in cwl_utils.pack (which is derived from sbpack's cwlpack)

  • it puts step processes inline instead of in a $graph.
  • therefore the id fields are not prefixed with their original step names

Other test failures might be due to errors in cwl_utils.pack itself

  • not including all $schemas in the parent $schemas

@lgtm-com
Copy link

lgtm-com bot commented Sep 2, 2022

This pull request fixes 3 alerts when merging 8af88ce into 2a2216b - view on LGTM.com

fixed alerts:

  • 3 for Module-level cyclic import

@lgtm-com
Copy link

lgtm-com bot commented Sep 2, 2022

This pull request fixes 3 alerts when merging cbc0a69 into 2a2216b - view on LGTM.com

fixed alerts:

  • 3 for Module-level cyclic import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant