fix: update dockerfile and requirements.txt to bring in line with ind…#14
fix: update dockerfile and requirements.txt to bring in line with ind…#14
Conversation
…ex.commoncrawl.org
wumpus
left a comment
There was a problem hiding this comment.
Seems like awscli is installed twice, once by apt and once by pip?
Well, sort of - I assume the one in requirements.txt is to support folks not using docker/installing directly on local. (That was there before my change - I just had un-commented the requirements.txt one inadvertantly) Let me try quick to confirm we can remove the docker one, and be covered only by the requirements.txt for both cases. |
|
A few things @wumpus bottom line up front - I actually think we should remove that install-collections script from docker build all together. details:
|
…i from docker and requirements.txt - data doesn't belong directly in docker image
|
@wumpus I updated Readme, requirements, and docker to be in alignment with that POV explained in last comment. |
|
@sebastian-nagel looking forward to your comments! |
…irements and versions for 3.9 on intel
Uh oh!
There was an error while loading. Please reload this page.