fix: correct sample_point used for postgis geocoding #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commonknowledge-bot
deployed
to
feature/map-1042-fix-output-area-postgis-geocoding-issue - meep-database PR #228
Render
Active
commonknowledge-bot
temporarily deployed
to
feature/map-1042-fix-output-area-postgis-geocoding-issue - meep-intelligence-hub-backend PR #228
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feature/map-1042-fix-output-area-postgis-geocoding-issue - meep-intelligence-hub-backend PR #228
Render
Destroyed
joaquimds
force-pushed
the
feature/map-1042-fix-output-area-postgis-geocoding-issue
branch
from
27c8e16 to
4a5dfb9
Compare
commonknowledge-bot
temporarily deployed
to
feature/map-1042-fix-output-area-postgis-geocoding-issue - meep-intelligence-hub-frontend PR #228
Render
Destroyed
commonknowledge-bot
had a problem deploying
to
feature/map-1042-fix-output-area-postgis-geocoding-issue - meep-intelligence-hub-worker PR #228
Render
Failure
commonknowledge-bot
temporarily deployed
to
feature/map-1042-fix-output-area-postgis-geocoding-issue - meep-intelligence-hub-frontend PR #228
Render
Destroyed
joaquimds
force-pushed
the
feature/map-1042-fix-output-area-postgis-geocoding-issue
branch
from
4a5dfb9 to
f5b8458
Compare
commonknowledge-bot
deployed
to
feature/map-1042-fix-output-area-postgis-geocoding-issue - meep-intelligence-hub-worker PR #228
Render
Active
Member
|
Grand, happy for this to be merged as the tests are just about Mailchimp test rig failures @joaquimds |
joaquimds
force-pushed
the
feature/map-1042-fix-output-area-postgis-geocoding-issue
branch
from
f5b8458 to
6889a04
Compare
commonknowledge-bot
temporarily deployed
to
feature/map-1042-fix-output-area-postgis-geocoding-issue - meep-intelligence-hub-backend PR #228
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feature/map-1042-fix-output-area-postgis-geocoding-issue - meep-intelligence-hub-worker PR #228
Render
Destroyed
joaquimds
deleted the
feature/map-1042-fix-output-area-postgis-geocoding-issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When geocoding an Area, uses
area.polygon.point_on_surfaceinstead ofcentroidto return a point that is definitely inside the area. Also makes sure that thepostcode_dataalways uses theAreathat was matched by code, over the geocoding results.Motivation and Context
https://linear.app/commonknowledge/issue/MAP-1042/fix-output-area-postgis-geocoding-issue