Fix GitHub Actions runs#120
Closed
Wissididom wants to merge 1 commit intocommuni:masterfrom
Wissididom:fix-builds
Closed
Fix GitHub Actions runs#120Wissididom wants to merge 1 commit intocommuni:masterfrom Wissididom:fix-builds
Wissididom wants to merge 1 commit intocommuni:masterfrom
Wissididom:fix-builds
Conversation
Author
|
It broke with my last force-push where I only updated the codecov action so something outside of this PR changed. Since I don't really think this PR gets merged anytime soon given it is open since Oct 2023, I'll close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
actions/cachebecausejurplel/install-qt-action@v4can do that by itself nowilammy/msvc-dev-cmdto set environment variables needed for the windows Build step. That action usesvswhereto find thevcvars64.batfile that sets the environment variables and runs it. This replaces callingvcvars64.batmanually.The main problem was that Visual Studio 2019 was hardcoded in the GitHub Actions workflow, and the current
windows-latest(at the time of writingwindows-2022, Source) does only have Visual Studio 2022 installed.