Skip to content

Fix unsubscription when not yet subscribed #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vrslev merged 1 commit into from
Feb 3, 2025
Merged

Fix unsubscription when not yet subscribed #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/faststream-stomp/faststream_stomp/subscriber.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ def __init__(
self.headers = headers
self.on_suppressed_exception = on_suppressed_exception
self.suppressed_exception_classes = suppressed_exception_classes
self._subscription: stompman.Subscription | None = None

super().__init__(
no_ack=self.ack == "auto",
no_reply=True,
Expand Down Expand Up @@ -93,7 +95,8 @@ async def start(self) -> None:
)

async def close(self) -> None:
await self._subscription.unsubscribe()
if self._subscription:
await self._subscription.unsubscribe()
await super().close()

async def get_one(self, *, timeout: float = 5) -> None: ...
Expand Down