Skip to content

Hopefully it works now #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adamnsm1 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Hopefully it works now #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17372bf
Hopefully it works now
adamnsm1 Dec 12, 2017
89bad8a
Added sleep before dif, test is much less flaky
adamnsm1 Dec 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/test/main.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ cd build/test

run_test ./ErasureCodeTest
# TODO(LINKIWI): investigate failure root cause
# run_test ./ReadWriteTest
run_test ./ReadWriteTest
run_test ./DeleteTest
run_test "./NameNodeTest --gtest_filter=-*Performance*"
run_test ./NativeFsTest
Expand Down
3 changes: 2 additions & 1 deletion test/integration/ReadWriteTest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ TEST(ReadWriteTest, testReadWrite) {
// Check that its contents match.
ASSERT_EQ(0,
system("diff expected_testfile1234 actual_testfile1234 > "
"dev/null"));
"/dev/null"));
system("hdfs dfs -fs hdfs://localhost:5351 -rm "
"/f");
}
Expand All @@ -88,6 +88,7 @@ TEST(ReadWriteTest, testConcurrentRead) {
"-cat /f > temp"
+ std::to_string(i)).c_str());
// Check that its contents match.
sleep(10);
ASSERT_EQ(0,
system(("diff expected_testfile1234 temp" + std::to_string(i)
+ " > /dev/null").c_str()));
Expand Down