-
Notifications
You must be signed in to change notification settings - Fork 30
Add Windows Emscripten build of xeus-cpp to ci #647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mcbarton
wants to merge
5
commits into
compiler-research:main
Choose a base branch
from
mcbarton:Add-Windows-Emscripten-build-of-xeus-cpp-to-ci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add Windows Emscripten build of xeus-cpp to ci #647
mcbarton
wants to merge
5
commits into
compiler-research:main
from
mcbarton:Add-Windows-Emscripten-build-of-xeus-cpp-to-ci
+71
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #647 +/- ##
=======================================
Coverage 79.75% 79.75%
=======================================
Files 9 9
Lines 3957 3957
=======================================
Hits 3156 3156
Misses 801 801 🚀 New features to boost your workflow:
|
bfac490
to
f5be4c6
Compare
4 tasks
For an Emscripten build of xeus-cpp to be possible on a Windows platform, the changes in this PR in xeus-cpp are required compiler-research/xeus-cpp#362 |
f5be4c6
to
b981887
Compare
b981887
to
8e8716f
Compare
8e8716f
to
c307b6f
Compare
c307b6f
to
62f4571
Compare
62f4571
to
58bfe95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
This PR adds a Windows Emscripten build of xeus-cpp to ci
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist