-
Notifications
You must be signed in to change notification settings - Fork 33
Initialize all ASM Parsers in the interpreter #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
=======================================
Coverage 81.03% 81.03%
=======================================
Files 9 9
Lines 4213 4214 +1
=======================================
+ Hits 3414 3415 +1
Misses 799 799
🚀 New features to boost your workflow:
|
clang-tidy review says "All clean, LGTM! 👍" |
I guess we can add a test with inline assembly to make sure this does not regress. |
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.