Skip to content

Conversation

aaronj0
Copy link
Collaborator

@aaronj0 aaronj0 commented Sep 25, 2025

No description provided.

@aaronj0 aaronj0 requested a review from vgvassilev September 25, 2025 14:24
Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.03%. Comparing base (0aa859b) to head (afaa8de).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #724   +/-   ##
=======================================
  Coverage   81.03%   81.03%           
=======================================
  Files           9        9           
  Lines        4213     4214    +1     
=======================================
+ Hits         3414     3415    +1     
  Misses        799      799           
Files with missing lines Coverage Δ
lib/CppInterOp/CppInterOpInterpreter.h 88.08% <100.00%> (+0.06%) ⬆️
Files with missing lines Coverage Δ
lib/CppInterOp/CppInterOpInterpreter.h 88.08% <100.00%> (+0.06%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@vgvassilev
Copy link
Contributor

I guess we can add a test with inline assembly to make sure this does not regress.

Copy link
Contributor

github-actions bot commented Oct 1, 2025

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

github-actions bot commented Oct 2, 2025

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

github-actions bot commented Oct 2, 2025

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaronj0 aaronj0 merged commit fe3de3c into compiler-research:main Oct 2, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants