Run browser tests in safari #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
==========================================
- Coverage 82.10% 81.78% -0.32%
==========================================
Files 20 20
Lines 950 950
Branches 87 87
==========================================
- Hits 780 777 -3
- Misses 170 173 +3 see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
mcbarton
changed the title
mcbarton
force-pushed
the
Run-browser-tests-in-safari
branch
from
5efac06 to
88566ee
Compare
4 tasks
vgvassilev
reviewed
Jul 25, 2025
@vgvassilev Yes it will fail if something is broken, because emrun will catch the non zero exit code, just like the other browsers. Selenium and safaridriver are just used to open the webpage in Safari, then emrun gets the output from the tests running (including the return value). |
mcbarton
force-pushed
the
Run-browser-tests-in-safari
branch
from
88566ee to
34e8bf8
Compare
|
I will update this PR soon to use the relative path to safari test script to be consistent with what cppinterop does |
mcbarton
force-pushed
the
Run-browser-tests-in-safari
branch
from
f82d694 to
2f902c9
Compare
mcbarton
force-pushed
the
Run-browser-tests-in-safari
branch
from
2f902c9 to
adcf86a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
Fixes # (issue)
Type of change
Please tick all options which are relevant.