Open
Conversation
Contributor
Author
|
Now I understand a bit more about how horrible dates are to work I can see that incorporating something like this is very complicated. However I'm finding the addDuration methods useful in my project (after fixing some glaring bugs) so I'll just leave it here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having a lot of problems dealing with interoperability between the native js dates and the tezos duration types - mostly because the native JS dates are in milliseconds and the tezos dates are in seconds (but also because durations take a string as input)
This is my naive attempt to address this. I don't know enough about how bindings work to figure out how to input tezDate into the contracts via entrypoints and deploy - but I got around this by adding a 'toDate' method.
If there is a much easier way to deal with this problem just using inbuilt methods or something, please just let me know!
If something like this is useful, I'm happy to write more complete tests