Skip to content

Fix duplicate environment blocks in docker-compose.prod.yml #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jthrilly merged 2 commits into from
Feb 9, 2026
Merged

Fix duplicate environment blocks in docker-compose.prod.yml #611

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f282b1
Initial plan
Copilot Feb 9, 2026
6f25475
Fix duplicate environment blocks in docker-compose.prod.yml
Copilot Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions docker-compose.prod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
services:
fresco:
environment:
- DATABASE_URL=postgresql://postgres:postgres@postgres:5432/postgres
- DATABASE_URL_UNPOOLED=postgresql://postgres:postgres@postgres:5432/postgres
- PUBLIC_URL=https://mywebsite.com
- UPLOADTHING_TOKEN='token'
image: 'ghcr.io/complexdatacollective/fresco:latest'
depends_on:
postgres:
Expand All @@ -19,6 +14,8 @@ services:
environment:
DATABASE_URL: postgresql://${POSTGRES_USER}:${POSTGRES_PASSWORD}@postgres:5432/fresco
DATABASE_URL_UNPOOLED: postgresql://${POSTGRES_USER}:${POSTGRES_PASSWORD}@postgres:5432/fresco
Comment on lines 15 to 16
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DATABASE_URL/DATABASE_URL_UNPOOLED point to the fresco database, but the postgres service is configured with POSTGRES_DB=postgres (so it will initialize a postgres database by default). This mismatch will cause connection failures on a fresh volume unless the fresco DB is created elsewhere. Align the DB name by either changing POSTGRES_DB to fresco or updating the URLs to use the same database name (ideally via a shared variable).

Copilot uses AI. Check for mistakes.
PUBLIC_URL: https://mywebsite.com
UPLOADTHING_TOKEN: token
Comment on lines +17 to +18
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PUBLIC_URL and especially UPLOADTHING_TOKEN are hardcoded here while an env_file: .env is also loaded; environment values take precedence over env_file, so this will override any real values provided via .env (and encourages committing secrets). Prefer referencing variables (e.g. ${PUBLIC_URL} / ${UPLOADTHING_TOKEN}) or remove these entries and supply them via .env/secrets at deploy time.

Suggested change
PUBLIC_URL: https://mywebsite.com
UPLOADTHING_TOKEN: token
PUBLIC_URL: ${PUBLIC_URL}
UPLOADTHING_TOKEN: ${UPLOADTHING_TOKEN}

Copilot uses AI. Check for mistakes.
env_file:
- .env

Expand Down