Skip to content

chore: fix old lint issues#385

Merged
marcusburghardt merged 5 commits intocomplytime:mainfrom
marcusburghardt:lint-issues
Feb 27, 2026
Merged

chore: fix old lint issues#385
marcusburghardt merged 5 commits intocomplytime:mainfrom
marcusburghardt:lint-issues

Conversation

@marcusburghardt
Copy link
Contributor

Summary

Fix lint issues identified in this CI execution: https://github.com/complytime/complyctl/actions/runs/22311312961

Related Issues

Review Hints

Review CI checks.

@marcusburghardt marcusburghardt requested a review from a team as a code owner February 23, 2026 16:09
@marcusburghardt marcusburghardt changed the title Lint issues chore: fix old lint issues Feb 23, 2026
@sonupreetam
Copy link
Contributor

sonupreetam commented Feb 24, 2026

@marcusburghardt I think the workflows are failing, the PR #382 can be approved first for CI failure and then the ci_auto_review workflow failure. Apart from that everything LGTM.

sonupreetam
sonupreetam previously approved these changes Feb 24, 2026
Copy link
Contributor

@sonupreetam sonupreetam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcusburghardt
Copy link
Contributor Author

@sonupreetam , there last commit removed an unnecessary line that was causing shellcheck to fail

Copy link
Contributor

@sonupreetam sonupreetam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
It was also causing shellcheck to fail.

Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
@marcusburghardt
Copy link
Contributor Author

Rebased

Copy link
Member

@qduanmu qduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I saw there is a discussion in slack about merging commits here into #381, and already there.

@marcusburghardt marcusburghardt merged commit 797170f into complytime:main Feb 27, 2026
25 checks passed
@marcusburghardt marcusburghardt deleted the lint-issues branch February 27, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants