Build and package compiler runtime resources #1046
Open
+243
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
reviewed
Oct 20, 2025
| run: | | ||
| $litOutput = python ${{ github.workspace }}/SourceCache/llvm-project/llvm/utils/lit/lit.py --version | ||
| $litVersion = ($litOutput | Select-String -Pattern 'lit (\d+)' | ForEach-Object { $_.Matches[0].Groups[1].Value }) | ||
| echo "llvm-version=$litVersion" >> $env:GITHUB_OUTPUT |
There was a problem hiding this comment.
This isn't entirely guaranteed to be correct. lit is available as a separate pip project as well.
There was a problem hiding this comment.
not sure i understand what you mean?
There was a problem hiding this comment.
Mostly that I'm not sure if we should be using lit as the source of the version information.
There was a problem hiding this comment.
@compnerd should we have this as an input to the build? or is there a better way to get the version?
mhegazy
force-pushed
the
upstream-compiler-rt
branch
from
034e8b3 to
33d3228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not building or packaging compiler-rt. this brings the changes in build.ps1 over to CI.
Here is a downstream run:https://github.com/thebrowsercompany/swift-build/actions/runs/18619136557