Add PURL on package page and accept them in security advisories API #1574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naderman
reviewed
Sep 30, 2025
| // resolve Package-URL to package names https://github.com/package-url/purl-spec/blob/main/PURL-SPECIFICATION.rst | ||
| $packageNames = array_map( | ||
| fn ($name) => Preg::replace('{^pkg:/?/?composer/([^/]+/[^/@?]+).*}', '$1', $name), | ||
| $packageNames |
There was a problem hiding this comment.
Wonder if this needs to parse the purl more completely then and reject if the repository_url is something other than packagist.org?
There was a problem hiding this comment.
Nevermind, since the advisory API isn't restricted to packages actually served by this repo, doesn't matter what repo is in the purl.
naderman
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1497
It's not very elegant but just adds it on the package page at the bottom of the sidebar like this:
I'm open for better suggestions but I don't think this should be very prominent tbh..
As specified here https://github.com/package-url/purl-spec/blob/main/types-doc/composer-definition.md and https://github.com/package-url/purl-spec/blob/main/types/composer-definition.json