fix(packaging): bundle fpcalc, disable UPX, surface mypy errors#3
Merged
fix(packaging): bundle fpcalc, disable UPX, surface mypy errors#3
Conversation
…rrors - Replace chromaprint.dll search with fpcalc.exe in tunecover.spec so audio fingerprinting works out-of-the-box on Windows builds - Add PyInstaller bundle detection in _find_fpcalc_binary() for both one-folder and one-file frozen builds - Disable UPX on Windows to prevent Qt DLL runtime crashes - Replace `mypy || true` with `continue-on-error: true` in CI so type errors show as yellow warnings instead of being silently swallowed
…ndows CI Clearing os.environ removes USERPROFILE/HOMEDRIVE which makes Path.home() raise RuntimeError on Windows. Using "FreeBSD" as the mock platform ensures step 5 has no common paths to check.
comxd
force-pushed
the
fix/packaging-improvements
branch
from
3890f30 to
c602d2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fpcalc.exeon Windows so audio fingerprinting works out-of-the-box (was completely broken)mypy || truewithcontinue-on-error: trueso type errors show as yellow warnings in CIChanges
packaging/tunecover.spec— replacechromaprint.dllsearch withfpcalc.exe, disable UPX on EXE + COLLECTsrc/core/fingerprint.py— add PyInstaller bundle detection (one-folder + one-file mode) in_find_fpcalc_binary()tests/test_fingerprint.py— 4 new regression tests for frozen build fpcalc detection.github/workflows/ci.yml—continue-on-error: trueon mypy stepTest plan
make lintpassesmake testpasses (2317 passed, 41 skipped)