ENH(TST): test workaround for decorating static and class methods#40
Draft
yarikoptic wants to merge 1 commit intocon:masterfrom
Draft
ENH(TST): test workaround for decorating static and class methods#40yarikoptic wants to merge 1 commit intocon:masterfrom
yarikoptic wants to merge 1 commit intocon:masterfrom
Conversation
I am not yet 100% sure but I think it is something which could be addressed
within joblib itself: to account for peculiarity of Python"s
@{class,static}method helpers which are classes themselves which proxy (instead
of just simply decorating) the __func__ of underlying function/method.
4652285 to
ab0c1f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not yet 100% sure but I think it is something which could be addressed
within joblib itself: to account for peculiarity of Python"s
@{class,static}method helpers which are classes themselves which proxy (instead
of just simply decorating) the
__func__of underlying function/method.