WIP: Python rewrite

.github/workflows/ci.yml

@@ -1,129 +1,54 @@
+---
 name: CI
 
 on:
   push:
-    branches: [ main, enhs ]
+    # TODO: remove redesign-python after merge
+    branches: [main, redesign-python]
   pull_request:
-    branches: [ main ]
+    branches: [main]
 
 jobs:
-  shellcheck:
-    name: ShellCheck
+  lint:
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
-
-      - name: Run shellcheck on setup-yolo.sh
-        run: shellcheck setup-yolo.sh
+      - uses: actions/checkout@v4
+      - uses: astral-sh/setup-uv@v5
+      - run: uv venv && uv pip install -e ".[dev]"
+      - uses: pre-commit/action@v3.0.1
 
-      - name: Run shellcheck on bin/yolo
-        run: shellcheck bin/yolo
-
-  unit-tests:
-    name: Unit Tests (BATS)
-    strategy:
-      matrix:
-        os: [ubuntu-latest, macos-latest]
-    runs-on: ${{ matrix.os }}
+  codespell:
+    runs-on: ubuntu-latest
     steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
+      - uses: actions/checkout@v4
+      - uses: codespell-project/actions-codespell@v2
         with:
-          submodules: true
-
-      - name: Install bats
-        run: |
-          if command -v brew &>/dev/null; then
-            brew install bats-core
-          else
-            sudo apt-get update && sudo apt-get install -y bats
-          fi
-
-      - name: Run tests
-        run: bats tests/
+          skip: ./design/legacy
 
-  test-setup:
-    name: Test Setup Script
+  shellcheck:
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
-
-      - name: Install podman
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y podman
-
-      - name: Test setup-yolo.sh (build only)
-        run: |
-          # Run setup with no input to skip installation prompt
-          # This will build the image and exit when asking about installation
-          echo "n" | ./setup-yolo.sh || true
-
-          # Verify the image was built
-          podman image exists con-bomination-claude-code
-
-      - name: Verify yolo script syntax
-        run: |
-          bash -n bin/yolo
-          echo "✓ Yolo script has valid syntax"
-
-      - name: Test yolo script help (dry run)
-        run: |
-          # Create a mock podman command that just echoes what would run
-          mkdir -p ~/test-bin
-          cat > ~/test-bin/podman << 'EOF'
-          #!/bin/bash
-          echo "PODMAN COMMAND:"
-          echo "podman $@"
-          exit 0
-          EOF
-          chmod +x ~/test-bin/podman
-
-          # Add to PATH and test
-          export PATH="$HOME/test-bin:$PATH"
-
-          # Verify our mock is used
-          which podman
-
-          # Test various yolo invocations
-          echo "Testing: yolo"
-          ./bin/yolo || true
-
-          echo "Testing: yolo -- \"help with code\""
-          ./bin/yolo -- "help with code" || true
-
-          echo "Testing: yolo -v /data:/data --"
-          ./bin/yolo -v /data:/data -- || true
+      - uses: actions/checkout@v4
+      - uses: ludeeus/action-shellcheck@master
+        with:
+          scandir: image-extras
 
-  integration-test:
-    name: Integration Test
+  unit-tests:
     runs-on: ubuntu-latest
-    needs: [shellcheck, test-setup]
     steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
-
-      - name: Install podman
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y podman
-
-      - name: Run full setup (automated)
-        run: |
-          # Answer 'no' to installation prompt
-          echo "n" | ./setup-yolo.sh
+      - uses: actions/checkout@v4
+      - uses: astral-sh/setup-uv@v5
+      - run: uv venv && uv pip install -e ".[dev]"
+      - run: .venv/bin/pytest -m "not integration" -v
 
-      - name: Verify container image
-        run: |
-          podman images
-          podman image exists con-bomination-claude-code
-          echo "✓ Container image successfully built"
-
-      - name: Test container can start
-        run: |
-          # Test that the container starts and can run a basic command
-          # We'll use --help which doesn't require authentication
-          podman run --rm con-bomination-claude-code claude --help
-          echo "✓ Container runs successfully"
+  integration-tests:
+    runs-on: ubuntu-latest
+    needs: [lint, unit-tests]
+    steps:
+      - uses: actions/checkout@v4
+      - uses: astral-sh/setup-uv@v5
+      - run: uv venv && uv pip install -e ".[dev]"
+      - name: Build base image
+        run: podman build -f images/Containerfile.base -t yolo-base images/
+      - name: Run integration tests
+        run: .venv/bin/pytest -m integration -v

.gitignore

@@ -0,0 +1,6 @@
+.venv/
+__pycache__/
+*.egg-info/
+.local-notes/
+.yolo/
+!src/yolo/demo/.yolo/

.gitmodules

@@ -1,6 +1,6 @@
 [submodule "tests/test_helper/bats-support"]
-	path = tests/test_helper/bats-support
+	path = legacy/tests/test_helper/bats-support
 	url = https://github.com/bats-core/bats-support.git
 [submodule "tests/test_helper/bats-assert"]
-	path = tests/test_helper/bats-assert
+	path = legacy/tests/test_helper/bats-assert
 	url = https://github.com/bats-core/bats-assert.git

.pre-commit-config.yaml

@@ -0,0 +1,21 @@
+---
+repos:
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.11.6
+    hooks:
+      - id: ruff
+      - id: ruff-format
+
+  - repo: https://github.com/adrienverge/yamllint
+    rev: v1.37.1
+    hooks:
+      - id: yamllint
+        args: [--strict]
+        exclude: ^design/legacy/
+
+  - repo: https://github.com/shellcheck-py/shellcheck-py
+    rev: v0.10.0.1
+    hooks:
+      - id: shellcheck
+        files: \.sh$
+        exclude: ^design/legacy/

.yamllint.yml

@@ -0,0 +1,6 @@
+---
+extends: default
+rules:
+  truthy:
+    # YAML spec treats bare 'on' as true, which breaks GitHub Actions 'on:' key
+    check-keys: false

CLAUDE.md

@@ -0,0 +1,45 @@
+**Before writing files, check if CLAUDE.md, design docs, or tests need updating to reflect your changes.**
+
+## Git workflow
+
+- Make clean, atomic commits — one feature or fix per commit.
+- Run `pre-commit run --files <staged files>` before attempting `git commit` to catch formatting issues early.
+
+## Python
+
+- Always import at the top of the file unless there's a good reason not to.
+
+## Project
+
+yolo runs Claude Code safely in a rootless Podman container with full autonomy.
+
+Currently being rewritten from bash to Python. Legacy code is in `design/legacy/`.
+
+## Key files
+
+- `SPEC.md` — current specification (source of truth for behavior)
+- `design/HACK_DECISIONS.md` — locked design decisions, do not revisit
+- `design/LEGACY_SPEC.md` — spec of the legacy bash implementation
+- `tests/features_to_test.md` — checklist of things that need tests
+
+## Development
+
+```
+uv venv .venv && source .venv/bin/activate
+uv pip install -e ".[dev]"
+pytest
+```
+
+Entry point is `yo` (temporary, becomes `yolo` at cutover).
+
+## Architecture
+
+- `src/yolo/config.py` — YAML config loading from 5 locations (defaults + 4 user)
+- `src/yolo/builder.py` — resolves extras, assembles build context, invokes podman
+- `src/yolo/cli.py` — click CLI (yo build, yo run, yo clip, yo demo)
+- `src/yolo/launcher.py` — assembles podman run command
+- `src/yolo/defaults/config.yaml` — default image-extras shipped with package
+- `images/Containerfile.base` — minimal debian base image
+- `images/Containerfile.extras` — layers image-extras on top
+- `image-extras/` — composable install scripts (apt.sh, python.sh, etc.)
+- `.local-notes/` — gitignored local working notes (issues, PRs, etc.)

CONTRIBUTING.md

@@ -0,0 +1,54 @@
+# Contributing
+
+## Setup
+
+```
+git clone https://github.com/con/yolo
+cd yolo
+uv venv .venv && source .venv/bin/activate
+uv pip install -e ".[dev]"
+pre-commit install
+```
+
+## Running tests
+
+```
+pytest
+```
+
+## Pre-commit hooks
+
+Hooks run automatically on commit:
+- **ruff** — Python lint and format
+- **yamllint** — YAML validation
+- **shellcheck** — shell script lint
+
+Run manually against all files:
+
+```
+pre-commit run --all-files
+```
+
+## Writing image-extras scripts
+
+Scripts live in `image-extras/`. Each script is a self-contained
+bash installer. Parameters are passed as env vars prefixed with
+`YOLO_{SCRIPTNAME}_{KEY}`:
+
+```bash
+#!/bin/bash
+# Env: YOLO_APT_PACKAGES (required)
+set -eu
+[ -z "${YOLO_APT_PACKAGES:-}" ] && { echo "apt.sh: YOLO_APT_PACKAGES required"; exit 1; }
+sudo apt-get install -y $YOLO_APT_PACKAGES
+```
+
+Config references scripts by name:
+
+```yaml
+image-extras:
+  - name: apt
+    packages: [zsh, fzf]
+```
+
+See `design/HACK_DECISIONS.md` for the full contract.