Open
Conversation
asmacdo
approved these changes
Apr 4, 2026
Member
asmacdo
left a comment
There was a problem hiding this comment.
Now that I have an escape plan if the dockerfile becomes unwieldy I'm not concerned with bloat.
FWIW I think this does highlight an improvement in my WIP way, which is that extras can take arguments ie, version.
Another small concern is that the go version is pinned by the extra. Might hit trouble if we add other go tools.
But since individual extras dont accept args I think let's just merge, and if we hit these issues we can fix then.
Member
Author
|
yeah, I actually also thought to fix it by version, would be prudent... let's do that... |
yarikoptic
commented
Apr 5, 2026
Member
|
Could you also add this to the spec? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as I am exploring it and @candleindark prepping example for STAMPED
FTR my invocation
locally ATM