Conversation
Add a `reason` field that can be used to file the archiving issue on the feedstock automatically. Fixes conda-forge#1324 Signed-off-by: Michał Górny <mgorny@quansight.com>
mgorny
left a comment
There was a problem hiding this comment.
This is the first approximation. I've inlined GitHub API since the script already did that, and the relevant endpoints are trivial to use.
| * [ ] Pinged the team for that feedstock for their input. | ||
| * [ ] Make sure you have opened an issue on the feedstock explaining why it was archived. | ||
| * [ ] Linked that issue in this PR description. | ||
| * [ ] Specified the reason for archiving the feedstock in the request. |
There was a problem hiding this comment.
I've added this step to make it clear that the workflow has changed. I'm wondering if we perhaps shouldn't an "or" here, also noting that people can link an existing issue instead.
| headers=headers, | ||
| json={ | ||
| "title": "Archive the feedstock", | ||
| "body": reason, |
There was a problem hiding this comment.
Bug #1324 mentioned cross-linking to the PR. If we wanted to do this, I think our best guess is parsing the merge commit (if any) for PR reference, though I think it's a bit gross, so let me know if you want that.
|
Gentle ping. (@jakirkham perhaps?) |
h-vetinari
left a comment
There was a problem hiding this comment.
What I'd almost consider more important than having a skeleton issue is to have a note in the README that adds language saying "this has been archived, if you need it, open a PR to unarchive on https://github.com/conda-forge/admin-requests"; in an ideal world, the README text would also refer to the admin-requests PR that triggered the archival (where people could then leave references to further feedstock issues if they exist).
Signed-off-by: Michał Górny <mgorny@quansight.com>
As in committing straight to the feedstock repository? And then removing that line when unarchiving the feedstock, or just assuming the next rerender will take care of that? |
Yes.
I think it'd be fine to let a rerender take care of it. Could be part of the text in the README, à la:
|
|
What about leaving the README alone and instead editing the repository description in the sidebar pointing to the issue? |
Completely fine by me as an approach! |
Add a
reasonfield that can be used to file the archiving issue on the feedstock automatically.Fixes #1324