Skip to content

Automatically file archive issue#1956

Open
mgorny wants to merge 2 commits intoconda-forge:mainfrom
mgorny:archive-issue
Open

Automatically file archive issue#1956
mgorny wants to merge 2 commits intoconda-forge:mainfrom
mgorny:archive-issue

Conversation

@mgorny
Copy link
Copy Markdown
Contributor

@mgorny mgorny commented Mar 23, 2026

Add a reason field that can be used to file the archiving issue on the feedstock automatically.

Fixes #1324

Add a `reason` field that can be used to file the archiving issue on the
feedstock automatically.

Fixes conda-forge#1324

Signed-off-by: Michał Górny <mgorny@quansight.com>
Copy link
Copy Markdown
Contributor Author

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the first approximation. I've inlined GitHub API since the script already did that, and the relevant endpoints are trivial to use.

* [ ] Pinged the team for that feedstock for their input.
* [ ] Make sure you have opened an issue on the feedstock explaining why it was archived.
* [ ] Linked that issue in this PR description.
* [ ] Specified the reason for archiving the feedstock in the request.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added this step to make it clear that the workflow has changed. I'm wondering if we perhaps shouldn't an "or" here, also noting that people can link an existing issue instead.

headers=headers,
json={
"title": "Archive the feedstock",
"body": reason,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug #1324 mentioned cross-linking to the PR. If we wanted to do this, I think our best guess is parsing the merge commit (if any) for PR reference, though I think it's a bit gross, so let me know if you want that.

@mgorny mgorny marked this pull request as ready for review March 23, 2026 17:00
@mgorny mgorny requested a review from a team as a code owner March 23, 2026 17:00
@mgorny
Copy link
Copy Markdown
Contributor Author

mgorny commented Apr 7, 2026

Gentle ping. (@jakirkham perhaps?)

Copy link
Copy Markdown
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I'd almost consider more important than having a skeleton issue is to have a note in the README that adds language saying "this has been archived, if you need it, open a PR to unarchive on https://github.com/conda-forge/admin-requests"; in an ideal world, the README text would also refer to the admin-requests PR that triggered the archival (where people could then leave references to further feedstock issues if they exist).

Comment thread examples/example-archive.yml Outdated
Signed-off-by: Michał Górny <mgorny@quansight.com>
@mgorny
Copy link
Copy Markdown
Contributor Author

mgorny commented Apr 8, 2026

What I'd almost consider more important than having a skeleton issue is to have a note in the README that adds language saying "this has been archived, if you need it, open a PR to unarchive on https://github.com/conda-forge/admin-requests"; in an ideal world, the README text would also refer to the admin-requests PR that triggered the archival (where people could then leave references to further feedstock issues if they exist).

As in committing straight to the feedstock repository? And then removing that line when unarchiving the feedstock, or just assuming the next rerender will take care of that?

@h-vetinari
Copy link
Copy Markdown
Member

As in committing straight to the feedstock repository?

Yes.

And then removing that line when unarchiving the feedstock, or just assuming the next rerender will take care of that?

I think it'd be fine to let a rerender take care of it. Could be part of the text in the README, à la:

This feedstock has been archived (see associated request and discussion/references therein). If this feedstock needs to be unarchived, please file an appropriate PR to https://github.com/conda-forge/admin-requests (with an explanation why un-archival is desirable). Then open a PR to this feedstock that updates the feedstock as necessary; don't forget to rerender the feedstock (either using the appropriate bot command in the PR, or by hand in your local checkout), which will also remove this blurb.

@jaimergp
Copy link
Copy Markdown
Member

What about leaving the README alone and instead editing the repository description in the sidebar pointing to the issue?

@h-vetinari
Copy link
Copy Markdown
Member

What about leaving the README alone and instead editing the repository description in the sidebar pointing to the issue?

Completely fine by me as an approach!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add logic to archive request to open issue automatically

3 participants