-
-
Notifications
You must be signed in to change notification settings - Fork 27
CFEP-12: Removing packages that violate the terms of the source package #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
isuruf
wants to merge
11
commits into
conda-forge:main
Choose a base branch
from
isuruf:cfep-12
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f86fa1c
Removing packages that violate the terms of the source package
isuruf 817e3c4
Update cfep-12.md
isuruf 316158c
Update cfep-12.md
isuruf 6ee70a7
Make it a week
isuruf e50d324
Update cfep-12.md
isuruf 437c7c0
Update cfep-12.md
isuruf 3e33738
Add more details
isuruf ae3c58b
moved->made private
isuruf e97969a
Add details on how to fix the package
isuruf c8f67cc
Maybe there's a downtime
isuruf a9c1ee9
Don't force push
isuruf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,87 @@ | ||||||
|
|
||||||
| <table> | ||||||
| <tr><td> Title </td><td> Removing packages that violate the terms of the source package</td> | ||||||
| <tr><td> Status </td><td> Draft </td></tr> | ||||||
| <tr><td> Author(s) </td><td> Isuru Fernando <isuruf@gmail.com></td></tr> | ||||||
| <tr><td> Created </td><td> Feb 26, 2020</td></tr> | ||||||
| <tr><td> Updated </td><td> Feb 26, 2020</td></tr> | ||||||
| <tr><td> Discussion </td><td> NA </td></tr> | ||||||
| <tr><td> Implementation </td><td> NA </td></tr> | ||||||
| </table> | ||||||
|
|
||||||
| ## Abstract | ||||||
|
|
||||||
| Source packages that we use to create conda packages have terms and conditions that allow | ||||||
| us to redistribute the package in binary form. This CFEP codifies the conduct when these | ||||||
| violations are reported. | ||||||
|
|
||||||
| ## Implementation | ||||||
|
|
||||||
| When a violation is brought to the attention of the Core team, the feedstock maintenance | ||||||
| team should be made aware by the Core team in a github issue on the feedstock and notified using the | ||||||
| github handles of the maintenance team members. | ||||||
|
|
||||||
| A week would be given to the maintenance team to respond to the claim and | ||||||
| another week would be given to address the issue. The feedstock maintenance team | ||||||
| may ask to extend the deadlines. | ||||||
|
|
||||||
| If the issue is not addressed after the specified time period, the package will be moved using | ||||||
| one of the following. | ||||||
|
|
||||||
| 1. Move the package to a private channel accessible only by core. | ||||||
|
|
||||||
| This is done if the violation is about terms of redistribution | ||||||
| Moving to a private channel that's available to only core makes the package in-house | ||||||
| and will not be distributed. | ||||||
|
|
||||||
| OR | ||||||
|
|
||||||
| 2. Delete the package | ||||||
|
|
||||||
| If the violation is not about terms of redistribution, but modifying the package by | ||||||
| creating a binary package, or if it's about storing the package in the cloud, | ||||||
| then the package will be deleted. | ||||||
|
|
||||||
| To do this, two core members must volunteer to archive the package locally. | ||||||
|
|
||||||
|
|
||||||
| To address the issue, the following conditions must be met, | ||||||
|
|
||||||
| 1. The recipe must be fixed according to the terms of the package. | ||||||
|
|
||||||
| 2. Existing package must be fixed according to the terms of the package | ||||||
|
|
||||||
| To facilitate this, infrastructure will be provided to add a file to the package. | ||||||
| (For eg: to add a copyright notice to the package). conda-package-handling (CPH) | ||||||
| can be used for extracting the package, adding a file and creating a new package. | ||||||
| This fixed package will be forced pushed. The new package will have a build string | ||||||
| appended or prepended depending on the use case. (For eg: blas=*=*_netlib will | ||||||
| have a build string prepended and hdf5=*=mpi_* will have build string appended.) | ||||||
|
|
||||||
| After the new packages are uploaded, the repodata will be patched for exact | ||||||
| pinnings and the old package removed from the CDN index. | ||||||
|
|
||||||
| When the repodata patching is live, the old packages will be removed. (Keep a copy somewhere?) | ||||||
|
|
||||||
| If the violation cannot be fixed by adding a file to the package, the packages | ||||||
| have to be deleted or made private according to the previous guidelines. | ||||||
|
|
||||||
|
|
||||||
| We suggest a message to the maintainers along the following lines | ||||||
|
|
||||||
| Hi! We (`@conda-forge/core`) have noticed that this package does not have | ||||||
| the license file required for us to be able to distribute this code. Nearly every | ||||||
| open-source license has such a requirement. It is extremely important that we | ||||||
| at `conda-forge` respect license restrictions and requirements such as this one | ||||||
| so that we can be good stewards of the open-source community. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| We are requesting that you add the correct license file to this feedstock. | ||||||
| If this is not done within two weeks, the packages from this feedstock be | ||||||
| moved to the broken label. If you'd like to extend this deadline or need | ||||||
| to discuss something with us, please feel free to respond to this issue. | ||||||
|
|
||||||
| We also very much appreciate the time you have taken to maintain this | ||||||
| feedstock and your understanding on this issue! | ||||||
| ## Copyright | ||||||
|
|
||||||
| All CFEPs are explicitly [CC0 1.0 Universal](https://creativecommons.org/publicdomain/zero/1.0/). | ||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.