-
Notifications
You must be signed in to change notification settings - Fork 176
Prepare 3.14 #1123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 3.14 #1123
Conversation
CHANGELOG.md
Outdated
| ## 2025-12-01 3.13.2: | ||
| ### Enhancements | ||
|
|
||
| * **Breaking change**: Replace custom Python script with `conda-standalone` calls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is a breaking change, should we at least bump to 3.14? If we should not, is it really a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, breaking changes are usually leading to a bump in the MAJOR version though, not in a MINOR, or even PATCH version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason why I added this to the news file is that under some circumstances (like using mamba version 2), Python is not added to the installer anymore unless requested in the constructor.yaml file. I think this is a breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's breaking in the sense of requiring v4, imo. It's a change in how the installer is bootstrapped, but not in a way that would impact users. If the installer implicitly required python but it was not added as an explicit dependency, it's really unlikely none of the other packages mentioned would have brought it in.
In that sense I'm inclined to call this release 3.14, not 4.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds fair to me. Adding Python implicitly was never really a feature, more of a necessary nuisance. It was never really transparent to the user why Python was always added. I removed the breaking change language from the change log.
jezdez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs version bump to 4.0
✂️ ✂️ ✂️ Snip, snip, release! ✂️ ✂️ ✂️